Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(embed): Add support for dark mode #6912

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 3, 2024

What

  • Added support for dark mode by using tailwindcss dark: modifier.
    • Dark mode is also supported on the landing page.

Why

Fix #5119
Fix #5966
Close #6842 (I should have said in either of the 2 issues above that I'm working on the patch, sorry for duplication)

Additional Info

↓ This image is outdated ("Want more customize?" section is not present in the latest code)

localhost_5173_ (16)

@gaearon
Copy link
Collaborator

gaearon commented Dec 3, 2024

Hi! Are there any design differences with #6842? I'm not completely opposed to explicit customization but I'd suggest separating that out — I'm not sure we want that. I'd like to better understand the design tweaks first though.

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Dec 3, 2024

I'm not completely opposed to explicit customization but I'd suggest separating that out — I'm not sure we want that. I'd like to better understand the design tweaks first though.

Okay, I'll separate the customization part (will create another issue once this or #6842 got merged).

Are there any design differences with #6842?

There might be slight color difference compared to that, but not so much as that in terms of design.
This implementation uses tailwindcss's dark: modifier, which is a recommended way to implement dark mode

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Dec 3, 2024

Okay, I'll separate the customization part.

done!

Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@mozzius mozzius merged commit de15f8e into bluesky-social:main Dec 11, 2024
6 checks passed
@JSDopefish
Copy link

JSDopefish commented Dec 11, 2024

I also agree. Thanks! Most useful. Can't wait to use it. I"m the guy who posted 5966.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change background color of embedded posts [Embeds] Dark/night theme
4 participants