-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(embed): Add support for dark mode #6912
Conversation
Hi! Are there any design differences with #6842? I'm not completely opposed to explicit customization but I'd suggest separating that out — I'm not sure we want that. I'd like to better understand the design tweaks first though. |
Okay, I'll separate the customization part (will create another issue once this or #6842 got merged).
There might be slight color difference compared to that, but not so much as that in terms of design. |
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
I also agree. Thanks! Most useful. Can't wait to use it. I"m the guy who posted 5966. |
What
dark:
modifier.Why
Fix #5119
Fix #5966
Close #6842 (I should have said in either of the 2 issues above that I'm working on the patch, sorry for duplication)
Additional Info
↓ This image is outdated ("Want more customize?" section is not present in the latest code)